[SPARK-29840][SQL] PostgreSQL dialect: cast to integer#26481
Closed
amanomer wants to merge 6 commits intoapache:masterfrom
Closed
[SPARK-29840][SQL] PostgreSQL dialect: cast to integer#26481amanomer wants to merge 6 commits intoapache:masterfrom
amanomer wants to merge 6 commits intoapache:masterfrom
Conversation
amanomer
changed the title
amanomer
changed the title
Contributor
Author
|
cc @cloud-fan |
Contributor
Author
|
Retest this please |
Member
|
memo: pending until #26472 merged. |
Member
|
Thank you for contribution, @amanomer . As you know, unfortunately, we decided to remove PostgreSQL dialect via SPARK-30125 (#26763). Sorry about that. I'll close this PR, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To make SparkSQL's
cast as intbehavior consistent with PostgreSQL when spark.sql.dialect is configured as PostgreSQL.Why are the changes needed?
SparkSQL and PostgreSQL have a lot different cast behavior between types by default. We should make SparkSQL's cast behavior be consistent with PostgreSQL when spark.sql.dialect is configured as PostgreSQL.
Does this PR introduce any user-facing change?
Yes. If user switches to PostgreSQL dialect now, they will
ByteType,TimestampTypeorDateTypetoIntegerTypeHow was this patch tested?
Added test cases.